Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with removing attributes #4927

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Fix bug with removing attributes #4927

merged 2 commits into from
Sep 9, 2022

Conversation

yasakova-anastasia
Copy link
Contributor

@yasakova-anastasia yasakova-anastasia commented Sep 9, 2022 •
edited
Loading

Motivation and context

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@yasakova-anastasia
Copy link
Contributor Author

/check

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022 •
edited
Loading

❌ Some checks failed
📄 See logs here

@bsekachev bsekachev self-assigned this Sep 9, 2022
bsekachev
bsekachev approved these changes Sep 9, 2022
View reviewed changes
Copy link
Member

@bsekachev bsekachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it works

@nmanovic nmanovic merged commit 6bb343f into develop Sep 9, 2022
@nmanovic nmanovic deleted the ay/fix-bug-with-attrs-removing branch September 9, 2022 13:06
@nmanovic nmanovic mentioned this pull request Sep 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsekachev bsekachev bsekachev approved these changes

@nmanovic nmanovic nmanovic approved these changes

Assignees

@bsekachev bsekachev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can not remove an attribute via admin panel (Parent field is required)
3 participants
@yasakova-anastasia @bsekachev @nmanovic