Fix ESlint problems / typescript for cvat-core #5027
Conversation
|
/check |
|
❌ Some checks failed |
|
/check |
|
❌ Some checks failed |
|
/check |
1 similar comment
|
/check |
|
✔️ All checks completed successfully |
cvat-ui/package.json
Outdated
| "cvat-canvas": "file:../cvat-canvas", | ||
| "cvat-canvas3d": "file:../cvat-canvas3d", | ||
| "cvat-core": "file:../cvat-core", |
There was a problem hiding this comment.
We should not add these dependencies here. It leads to bugs with yarn
They were deleted before to avoid it
There was a problem hiding this comment.
Hot reload does not work when change these packages
There was a problem hiding this comment.
I've updated the pr - tried to use yarn's link instead of file. Hot reload woks fine for me with that change. Could you try it?
| // | ||
| // SPDX-License-Identifier: MIT | ||
| import 'redux-thunk/extend-redux'; |
There was a problem hiding this comment.
Could you please explain this change?
There was a problem hiding this comment.
Recently I've been having such type error in cvat-ui:
Argument of type 'ThunkAction<{}, AnyAction>' is not assignable to parameter of type 'AnyAction'.ts(2345)
on each call to dispatch. This import solved the error.
|
/check |
|
✔️ All checks completed successfully |
Motivation and context
How has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.