Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled authentication via email #5037

Merged
merged 7 commits into from
Oct 7, 2022
Merged

Enabled authentication via email #5037

merged 7 commits into from
Oct 7, 2022

Conversation

klakhov
Copy link
Contributor

@klakhov klakhov commented Oct 4, 2022 •
edited
Loading

Motivation and context

  • Enable our users to authenticate using email
    email-auth1

  • Update Registration form so username is automatically generated from email, can be edited by user if needed
    email-auth2

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Marishka17
Marishka17 reviewed Oct 5, 2022
View reviewed changes
cvat/apps/iam/serializers.py Outdated Show resolved Hide resolved
cvat/apps/iam/serializers.py Outdated Show resolved Hide resolved
cvat/settings/email_settings.py Show resolved Hide resolved
cvat/apps/iam/serializers.py Outdated Show resolved Hide resolved
@klakhov
Copy link
Contributor Author

klakhov commented Oct 7, 2022

/check

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022 •
edited
Loading

❌ Some checks failed
📄 See logs here

@klakhov
Copy link
Contributor Author

klakhov commented Oct 7, 2022

/check

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022 •
edited
Loading

✔️ All checks completed successfully
📄 See logs here

Marishka17
Marishka17 approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@Marishka17 Marishka17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanovic nmanovic merged commit b7371ed into develop Oct 7, 2022
@nmanovic nmanovic deleted the kl/email-auth branch October 7, 2022 11:21
@arvfilippov arvfilippov mentioned this pull request Oct 14, 2022
Merged
7 tasks
@nmanovic nmanovic mentioned this pull request Nov 1, 2022
Closed
@nmanovic nmanovic mentioned this pull request Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marishka17 Marishka17 Marishka17 approved these changes

@azhavoro azhavoro Awaiting requested review from azhavoro azhavoro is a code owner

@bsekachev bsekachev Awaiting requested review from bsekachev bsekachev is a code owner

@nmanovic nmanovic Awaiting requested review from nmanovic

Assignees
No one assigned
Labels
server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klakhov @Marishka17 @nmanovic