-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: visibility and ignored information fail to be loaded (MOT dataset format) #5270
Conversation
continue | ||
|
||
track_id = ann.attributes.get('track_id') | ||
occluded = dm.util.cast(ann.attributes.pop('occluded', None), bool) is True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bool
casting can be too wide - e.g. bool('hello')
is True
. I'd suggest to compare with the expected value directly, i.e. pop(..., False) is True
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
outside=False, | ||
keyframe=True, | ||
z_order=ann.z_order, | ||
frame=frame_number, | ||
attributes=[], | ||
attributes=attributes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assignment might need to take into account the mutable
property of an attribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This happens later in the _import_attribute
function
Motivation and context
Fix #5231
How has this been tested?
Checklist
develop
branchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.