Simplify upload data for task #5498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/check |
|
❌ Some checks failed |
|
/check |
|
❌ Some checks failed |
Marishka17
changed the title
nmanovic
requested review from
zhiltsov-max
and removed request for
azhavoro
zhiltsov-max
requested changes
Dec 22, 2022
Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com>
…/opencv/cvat into mk/symplify_upload_data_for_task
|
/check |
|
❌ Some checks failed |
|
/check |
|
❌ Some checks failed |
Marishka17
changed the title
Marishka17
changed the title
Marishka17
force-pushed
the
mk/symplify_upload_data_for_task
branch
2 times, most recently
from
acdf9c5
to
c1eb340
Compare
Marishka17
force-pushed
the
mk/symplify_upload_data_for_task
branch
from
c1eb340
to
7cce69b
Compare
zhiltsov-max
approved these changes
Dec 27, 2022
nmanovic
reviewed
Dec 27, 2022
| images = [] | ||
| for i in range(count): | ||
| image = generate_image_file(f"{i}.jpeg", color=(i, i, i)) | ||
| prefix = prefixes[i] if prefixes else "" |
There was a problem hiding this comment.
It works only because len(prefixes) == count in the code. Probably it is a bug. Let's fix in your next PR.
7 tasks
nmanovic
pushed a commit
that referenced
this pull request
Dec 31, 2022
This PR fixes a problem with local running of tests introduced in #5498. When running tests locally, there can be multiple tags available, while we need the `dev` tag, which should be created right before tests are executed. - Added the missing image tag in the docker run command
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Jul 1, 2023
It's possible to specify only the manifest file and filename pattern for creating task with cloud storage data. The special characters supported now for the pattern are `*`, `?`, `[seq]`, `[!seq]`. Please see [here](https://github.com/opencv/cvat/blob/8898a8b2647514dd6f3f6ce83745b1ca8ef72bce/tests/python/rest_api/test_tasks.py#L686) for some examples of how to use this functionality. Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com>
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Jul 1, 2023
This PR fixes a problem with local running of tests introduced in cvat-ai#5498. When running tests locally, there can be multiple tags available, while we need the `dev` tag, which should be created right before tests are executed. - Added the missing image tag in the docker run command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
It's possible to specify only the manifest file and filename pattern for creating task with cloud storage data.
The special characters supported now for the pattern are
*,?,[seq],[!seq].Please see here for some examples of how to use this functionality.
How has this been tested?
Manually, added REST API test
Checklist
developbranch- [ ] I have linked related issues (read github docs)- [ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.