Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed chunk and preview cache usage #5569

Merged
merged 5 commits into from
Jan 11, 2023
Merged

Fixed chunk and preview cache usage #5569

merged 5 commits into from
Jan 11, 2023

Conversation

azhavoro
Copy link
Contributor

Motivation and context

Usage of diskcache.Cache class leads to ignorig cache settings from base.py

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@nmanovic nmanovic changed the title Fixed chank&preview cache usage Fixed chunk and preview cache usage Jan 11, 2023
cvat/apps/engine/cache.py Outdated Show resolved Hide resolved
cvat/apps/engine/cache.py Outdated Show resolved Hide resolved
Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanovic nmanovic merged commit 6c3e3c9 into develop Jan 11, 2023
@nmanovic nmanovic deleted the az/fix_cache branch January 11, 2023 14:33
@Marishka17
Copy link
Contributor

PR looks good to me, but I have several questions:

  • Why is it needed to increase the default number of SHARDS?
  • maybe need to make cache item keys more descriptive and the same?
    now it looks like this:
:1:djangohealtcheck_test
:1:1_0_Quality.COMPRESSED
:1:data_2_0_preview
:1:chunk_compressed_1_0
:1:local_preview_2_0
:1:cloud_preview_2_0
  • Should we remove the previous cache (I mean data/cache/cache.db)?

mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants