Fix HRNet dimension error on images with alpha channel #5570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmanovic
approved these changes
Jan 11, 2023
2 tasks
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Jul 1, 2023
This is pretty much the same fix applied to f-BRS in cvat-ai#5384. We've been using HRNet for a while and now an then we receive "500 errors" just as reported in cvat-ai#5299 when someone forgets to drop the alpha-channel from our images. ### Motivation and context The RuntimeError is a little bit different, but comes from the same issue: RGBA instead of RGB images: > RuntimeError: Given groups=1, weight of size [16, 3, 1, 1], expected input[*, 4, *, *] to have 3 channels, but got 4 channels instead. ### How has this been tested? I created a task with images with and w/o alpha channel, and the interactor works on both now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty much the same fix applied to f-BRS in #5384. We've been using HRNet for a while and now an then we receive "500 errors" just as reported in #5299 when someone forgets to drop the alpha-channel from our images.
Motivation and context
The RuntimeError is a little bit different, but comes from the same issue: RGBA instead of RGB images:
How has this been tested?
I created a task with images with and w/o alpha channel, and the interactor works on both now.
Checklist
developbranchI have updated the documentation accordinglyI have added tests to cover my changesI have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.