Downgrade NumPy used by HRNet #5574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigoberriel
force-pushed
the
fix-hrnet-numpy-version
branch
from
d31b808
to
e90e73f
Compare
|
@nmanovic please, let me know if there is anything else needed for this PR |
Signed-off-by: Rodrigo Berriel <rodrigo.berriel@gmail.com>
rodrigoberriel
force-pushed
the
fix-hrnet-numpy-version
branch
from
e90e73f
to
a89ab7b
Compare
2 tasks
SpecLad
reviewed
Mar 23, 2023
SpecLad
approved these changes
Mar 23, 2023
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Jul 1, 2023
HRNet uses `np.int` which throws an error for NumPy >= 1.24, because its deprecation was finally expired. This PR creates an additional step during HRNet function image build, downgrading NumPy for a version < 1.24. ### Motivation and context Closes cvat-ai#5571.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HRNet uses
np.intwhich throws an error for NumPy >= 1.24, because its deprecation was finally expired. This PR creates an additional step during HRNet function image build, downgrading NumPy for a version < 1.24.Motivation and context
Closes #5571.
How has this been tested?
I updated the CVAT locally and checked that I could successfully deploy HRNet on nuclio. After that, I tested the interactor on some images and everything is working as it should.
Checklist
developbranchI have updated the documentation accordinglyI have added tests to cover my changesI have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.