Code coverage #6173
Merged
Code coverage #6173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasakova-anastasia
requested review from
sizov-kirill,
azhavoro,
bsekachev,
Marishka17 and
nmanovic
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #6173 +/- ##
==========================================
Coverage ? 80.88%
==========================================
Files ? 311
Lines ? 35078
Branches ? 6333
==========================================
Hits ? 28372
Misses ? 6463
Partials ? 243
|
yasakova-anastasia
removed request for
mdacoca,
bsekachev,
nmanovic,
azhavoro and
Marishka17
|
@kirill-sizov, could you please review this PR? |
Marishka17
reviewed
May 22, 2023
sizov-kirill
reviewed
Jun 6, 2023
sizov-kirill
approved these changes
Jun 7, 2023
nmanovic
reviewed
Jun 8, 2023
nmanovic
reviewed
Jun 8, 2023
nmanovic
reviewed
Jun 8, 2023
nmanovic
reviewed
Jun 9, 2023
Dockerfile
Outdated
| @@ -178,6 +178,12 @@ COPY --chown=${USER} wait-for-it.sh manage.py backend_entrypoint.sh ${HOME}/ | |||
| COPY --chown=${USER} utils/ ${HOME}/utils | |||
| COPY --chown=${USER} cvat/ ${HOME}/cvat | |||
|
|
|||
| ARG COVERAGE_PROCESS_START | |||
| RUN if [ "${COVERAGE_PROCESS_START}" ]; then \ | |||
| python3 -m pip install --no-cache-dir coverage==7.2.3; \ | |||
There was a problem hiding this comment.
Why do we need the line? It should be installed by 75 line in the file.
There was a problem hiding this comment.
OK. Let's add the line in production.txt and add a comment that "to collect the coverage for rest api tests. It will be enabled only if COVERAGE_PROCESS_START env is defined." I believe it will be better for now.
nmanovic
approved these changes
Jun 12, 2023
SpecLad
added a commit
to SpecLad/cvat
that referenced
this pull request
Jun 26, 2023
It was accidentally disabled in cvat-ai#6173.
2 tasks
SpecLad
added a commit
that referenced
this pull request
Jun 27, 2023
It was accidentally disabled in #6173. Also, refactor the build steps to make the log easier to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.