Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accelerated SAM decoder, fixed serverless for EXIF rotated images #6275

Merged
merged 11 commits into from
Jun 13, 2023

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jun 9, 2023

Removed extra interpolation layer

Motivation and context

Fixed #6250

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev requested a review from mdacoca as a code owner June 10, 2023 09:46
@bsekachev bsekachev changed the title [WIP] Accelerated SAM decoder Accelerated SAM decoder, fixed serverless for EXIF rotated images Jun 10, 2023
@bsekachev bsekachev changed the title Accelerated SAM decoder, fixed serverless for EXIF rotated images [WIP] Accelerated SAM decoder, fixed serverless for EXIF rotated images Jun 12, 2023
@bsekachev
Copy link
Member Author

/check

@github-actions
Copy link
Contributor

github-actions bot commented Jun 12, 2023

❌ Some checks failed
📄 See logs here

@bsekachev bsekachev changed the title [WIP] Accelerated SAM decoder, fixed serverless for EXIF rotated images Accelerated SAM decoder, fixed serverless for EXIF rotated images Jun 12, 2023
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #6275 (a5e1f33) into develop (9a600f3) will decrease coverage by 0.54%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #6275      +/-   ##
===========================================
- Coverage    74.78%   74.24%   -0.54%     
===========================================
  Files          145      320     +175     
  Lines        16934    37249   +20315     
  Branches      3285     6748    +3463     
===========================================
+ Hits         12664    27657   +14993     
- Misses        4264     9309    +5045     
- Partials         6      283     +277     
Components Coverage Δ
cvat-ui 65.42% <ø> (-9.37%) ⬇️
cvat-server 82.26% <100.00%> (∅)

@bsekachev bsekachev merged commit 3b3f9ca into develop Jun 13, 2023
@bsekachev bsekachev deleted the bs/improved_decoder branch June 13, 2023 16:42
@azhavoro azhavoro mentioned this pull request Jun 16, 2023
bsekachev added a commit that referenced this pull request Jun 16, 2023
## \[2.4.7] - 2023-06-16
### Added
- \[API\] API Now supports the creation and removal of Ground Truth
jobs. (<#6204>)
- \[API\] We've introduced task quality estimation endpoints.
(<#6204>)
- \[CLI\] An option to select the organization.
(<#6317>)

### Fixed
- Issues with running serverless models for EXIF-rotated images.
(<#6275>)
- File uploading issues when using https configuration.
(<#6308>)
- Dataset export error with `outside` property of tracks.
(<#5971>)
- Broken logging in the TransT serverless function.
(<#6290>)

---------

Co-authored-by: Anastasia Yasakova <yasakova_anastasiya@mail.ru>
Co-authored-by: Mariia Acoca <39969264+mdacoca@users.noreply.github.com>
Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com>
Co-authored-by: klakhov <kirill.9992@gmail.com>
Co-authored-by: Roman Donchenko <roman@cvat.ai>
Co-authored-by: Kirill Sizov <kirill.sizov@cvat.ai>
Co-authored-by: Boris Sekachev <boris.sekachev@yandex.ru>
Co-authored-by: Paweł Kotiuk <kotiuk@zohomail.eu>
Co-authored-by: Nikita Manovich <nikita@cvat.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SAM model doesn't always get the border pixels
2 participants