Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove max file count #6292

Merged
merged 5 commits into from
Jun 13, 2023
Merged

Remove max file count #6292

merged 5 commits into from
Jun 13, 2023

Conversation

sizov-kirill
Copy link
Contributor

Motivation and context

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@codecov
Copy link

codecov bot commented Jun 12, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@e5ea213). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #6292   +/-   ##
==========================================
  Coverage           ?   62.96%           
==========================================
  Files              ?      289           
  Lines              ?    35694           
  Branches           ?     3480           
==========================================
  Hits               ?    22476           
  Misses             ?    13214           
  Partials           ?        4
Components Coverage Δ
cvat-ui 54.60% <0.00%> (?)
cvat-server 71.22% <0.00%> (?)

Marishka17
Marishka17 reviewed Jun 12, 2023
View reviewed changes
cvat/apps/engine/serializers.py Outdated Show resolved Hide resolved
cvat/settings/base.py Outdated
@@ -514,9 +514,7 @@ class CVAT_QUEUES(Enum):
DATA_UPLOAD_MAX_MEMORY_SIZE = 100 * 1024 * 1024 # 100 MB
DATA_UPLOAD_MAX_NUMBER_FIELDS = None # this django check disabled
DATA_UPLOAD_MAX_NUMBER_FILES = None
LOCAL_LOAD_MAX_FILES_COUNT = 500
LOCAL_LOAD_MAX_FILES_SIZE = 512 * 1024 * 1024 # 512 MB
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about LOCAL_LOAD_MAX_FILES_SIZE variable? It doesn't seem to be used anywhere. Should we delete it too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@bsekachev bsekachev mentioned this pull request Jun 13, 2023
Closed
sizov-kirill and others added 2 commits June 13, 2023 16:28
@sizov-kirill
remove LOCAL_LOAD_MAX_FILES_SIZE
5a548e4
@Marishka17
Update cvat/apps/engine/serializers.py
8f77270 
Co-authored-by: Maria Khrustaleva <maya17grd@gmail.com>
@nmanovic nmanovic merged commit e95c0a1 into develop Jun 13, 2023
@nmanovic nmanovic deleted the sk/remove-max-file-count branch June 13, 2023 18:08
@sizov-kirill sizov-kirill mentioned this pull request Jun 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marishka17 Marishka17 Marishka17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sizov-kirill @Marishka17 @nmanovic