Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation in AttributeSerializer #6447

Merged
merged 4 commits into from
Jul 20, 2023

Commits on Jul 19, 2023

  1. Configuration menu
    Copy the full SHA
    06f9229 View commit details
    Browse the repository at this point in the history
  2. Fix validation in AttributeSerializer

    The current implementation of `to_internal_value` doesn't call the base
    class method, which is supposed to carry out generic validation of
    serializer fields. This means that we essentially don't validate attribute
    fields beyond what is done incidentally by database contraints.
    
    Fix it by removing the overridden method entirely, and adding a special
    field class for the `values` field.
    SpecLad committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    d5c66e5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cffa49b View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Configuration menu
    Copy the full SHA
    8a2598c View commit details
    Browse the repository at this point in the history