Added simple prefetch analyzer #6695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #6695 +/- ##
===========================================
+ Coverage 81.35% 82.26% +0.91%
===========================================
Files 369 366 -3
Lines 39734 39771 +37
Branches 3504 3531 +27
===========================================
+ Hits 32324 32717 +393
+ Misses 7410 7054 -356
|
|
@klakhov , could you please look? |
klakhov
approved these changes
Aug 18, 2023
Merged
jonybekov
pushed a commit
to tezzro/cvat
that referenced
this pull request
Sep 6, 2023
<!-- Raise an issue to propose your change (https://github.com/opencv/cvat/issues). It helps to avoid duplication of efforts from multiple independent contributors. Discuss your ideas with maintainers to be sure that changes will be approved and merged. Read the [Contribution guide](https://opencv.github.io/cvat/docs/contributing/). --> <!-- Provide a general summary of your changes in the Title above --> ### Motivation and context Prefetch further chunks not only when isPlaying, but also when user goes from frame to frame manually Use cases it should work normally: * +1 sequence: 1 -> 2 -> 3 -> 4 * +1 sequence with revertable fallbacks: 1 -> 2 -> 3 -> 4 -> 3 -> 2 -> 3 -> 4 * +N sequence: 1 -> 11 -> 21 -> 31 (N < chunk size) * +N sequence with revertable fallbacks: 1 -> 11 -> 21 -> 31 -> 21 -> 11 -> 21 ->31 (N < chunk size) * Mixed sequence keeping increase order with revertable fallbacks (for example when navigating by keyframes forward/backward): 1 -> 3 -> 10 -> 15 -> 20 -> 15 -> 20 (max step < chunk size) Example it will not work: 1 -> 2 -> 3 -> 4 -> 1 -> 4 (sequence broken, memory to analize is stricted by **chunk size / 2** elements) So, if the sequence is broken algorithm will not recommend to prefetch next chunk. Broken sequence will be repaired at maximum on the next chunk (if +1, otherwise maybe later) if don't get broken again. ### How has this been tested? <!-- Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. --> ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I submit my changes into the `develop` branch - [x] I have added a description of my changes into the [CHANGELOG](https://github.com/opencv/cvat/blob/develop/CHANGELOG.md) file - [ ] I have updated the documentation accordingly - [ ] I have added tests to cover my changes - [ ] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)) - [x] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning)) ### License - [x] I submit _my code changes_ under the same [MIT License]( https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern.
2 tasks
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Oct 25, 2023
<!-- Raise an issue to propose your change (https://github.com/opencv/cvat/issues). It helps to avoid duplication of efforts from multiple independent contributors. Discuss your ideas with maintainers to be sure that changes will be approved and merged. Read the [Contribution guide](https://opencv.github.io/cvat/docs/contributing/). --> <!-- Provide a general summary of your changes in the Title above --> ### Motivation and context Prefetch further chunks not only when isPlaying, but also when user goes from frame to frame manually Use cases it should work normally: * +1 sequence: 1 -> 2 -> 3 -> 4 * +1 sequence with revertable fallbacks: 1 -> 2 -> 3 -> 4 -> 3 -> 2 -> 3 -> 4 * +N sequence: 1 -> 11 -> 21 -> 31 (N < chunk size) * +N sequence with revertable fallbacks: 1 -> 11 -> 21 -> 31 -> 21 -> 11 -> 21 ->31 (N < chunk size) * Mixed sequence keeping increase order with revertable fallbacks (for example when navigating by keyframes forward/backward): 1 -> 3 -> 10 -> 15 -> 20 -> 15 -> 20 (max step < chunk size) Example it will not work: 1 -> 2 -> 3 -> 4 -> 1 -> 4 (sequence broken, memory to analize is stricted by **chunk size / 2** elements) So, if the sequence is broken algorithm will not recommend to prefetch next chunk. Broken sequence will be repaired at maximum on the next chunk (if +1, otherwise maybe later) if don't get broken again. ### How has this been tested? <!-- Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. --> ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I submit my changes into the `develop` branch - [x] I have added a description of my changes into the [CHANGELOG](https://github.com/opencv/cvat/blob/develop/CHANGELOG.md) file - [ ] I have updated the documentation accordingly - [ ] I have added tests to cover my changes - [ ] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)) - [x] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning)) ### License - [x] I submit _my code changes_ under the same [MIT License]( https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Prefetch further chunks not only when isPlaying, but also when user goes from frame to frame manually
Use cases it should work normally:
Example it will not work:
1 -> 2 -> 3 -> 4 -> 1 -> 4 (sequence broken, memory to analize is stricted by chunk size / 2 elements)
So, if the sequence is broken algorithm will not recommend to prefetch next chunk.
Broken sequence will be repaired at maximum on the next chunk (if +1, otherwise maybe later) if don't get broken again.
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.