SDK: Fix FileExistsErrors on Windows when a dataset is loaded from cache
#6722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cache `atomic_writer` is supposed to overwrite the destination file, but `os.rename` doesn't do that on Windows. We have to use `os.replace` instead.
Codecov Report
@@ Coverage Diff @@
## develop #6722 +/- ##
===========================================
+ Coverage 82.25% 82.26% +0.01%
===========================================
Files 366 366
Lines 39771 39767 -4
Branches 3531 3531
===========================================
+ Hits 32714 32715 +1
+ Misses 7057 7052 -5
|
Merged
jonybekov
pushed a commit
to tezzro/cvat
that referenced
this pull request
Sep 6, 2023
…cache (cvat-ai#6722) `atomic_writer` is supposed to overwrite the destination file, but `os.rename` doesn't do that on Windows. We have to use `os.replace` instead.
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Oct 25, 2023
…cache (cvat-ai#6722) `atomic_writer` is supposed to overwrite the destination file, but `os.rename` doesn't do that on Windows. We have to use `os.replace` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
atomic_writeris supposed to overwrite the destination file, butos.renamedoesn't do that on Windows. We have to useos.replaceinstead.How has this been tested?
Manual testing.
Checklist
developbranch[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.