Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed nan values in .pcd files, fixed broken navigation in 3D workspace, updated three js #6862

Merged
merged 12 commits into from
Oct 6, 2023

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Sep 14, 2023

Motivation and context

  • Upgraded three js library
  • Fixed nan values
  • Fixed broken direct navigation
  • Not ignore intensity level from .bin lidar data, write it to .pcd

How has this been tested?

Resolved #6288

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev changed the title [WIP] Updated three.js 3D annotation view bug fixes Sep 15, 2023
@bsekachev bsekachev changed the title 3D annotation view bug fixes [WIP] 3D annotation view bug fixes Sep 15, 2023
@bsekachev bsekachev changed the title [WIP] 3D annotation view bug fixes 3D annotation view bug fixes Sep 15, 2023
@bsekachev bsekachev changed the title 3D annotation view bug fixes Fixed nan values in .pcd files, fixed broken navigation in 3D workspace, updated three js Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #6862 (86dd5ce) into develop (ae1dc1b) will decrease coverage by 0.02%.
The diff coverage is 75.47%.

@@             Coverage Diff             @@
##           develop    #6862      +/-   ##
===========================================
- Coverage    82.59%   82.58%   -0.02%     
===========================================
  Files          360      360              
  Lines        38867    38907      +40     
  Branches      3544     3566      +22     
===========================================
+ Hits         32104    32132      +28     
- Misses        6763     6775      +12     
Components Coverage Δ
cvat-ui 77.61% <74.50%> (-0.02%) ⬇️
cvat-server 87.13% <100.00%> (ø)

@bsekachev bsekachev requested review from klakhov and removed request for mdacoca, nmanovic, azhavoro and Marishka17 October 3, 2023 07:58
@bsekachev bsekachev merged commit 06bae53 into develop Oct 6, 2023
33 checks passed
@bsekachev bsekachev deleted the bs/3d branch October 9, 2023 12:45
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nan values in .pcd files causes annotations problems on 3D view
3 participants