Fix possible double writing of the uploaded client files in Upload-Multiple requests #6952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiltsov-max
changed the title
zhiltsov-max
changed the title
SpecLad
reviewed
Oct 11, 2023
Codecov Report
@@ Coverage Diff @@
## develop #6952 +/- ##
===========================================
- Coverage 82.59% 82.34% -0.26%
===========================================
Files 360 361 +1
Lines 38926 39169 +243
Branches 3570 3586 +16
===========================================
+ Hits 32150 32252 +102
- Misses 6776 6917 +141
|
|
Would it be possible to have this fix in the next release? Thank you very much! |
SpecLad
reviewed
Oct 16, 2023
SpecLad
reviewed
Oct 16, 2023
| task_id, _ = create_task(self._USERNAME, task_spec, task_data) | ||
|
|
||
| # check that the original chunk image have the original size | ||
| # this is less accurate than checking the uploaded file directly, but faster |
There was a problem hiding this comment.
Could you clarify why this is less accurate?
There was a problem hiding this comment.
Because we're not checking the original problem exactly, as it was with raw uploaded files. The chunks may get processed data, which can be correct for some foreign reasons, which can shadow the initial problem.
Co-authored-by: Roman Donchenko <roman@cvat.ai>
SpecLad
approved these changes
Oct 17, 2023
Merged
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Oct 25, 2023
…ltiple requests (cvat-ai#6952) Fixes cvat-ai#6878 In the case of big files (>2.5 MB by default), the uploaded files could be write-appended twice, leading to bigger raw file sizes than expected. This PR fixes the behavior by excluding repetitive writes where it was not supposed. - Fixed double append-writing of the uploaded files when Upload-Multiple requests are used - Fixed potential DB - disk inconsistencies in the case of upload errors - Added tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6878
In the case of big files (>2.5 MB by default), the uploaded files could be write-appended twice,
leading to bigger raw file sizes than expected. This PR fixes the behavior by excluding repetitive
writes where it was not supposed.
Motivation and context
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.