Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm-chart: add a way to easily set parameters for all backend pods #7148

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Nov 16, 2023

Motivation and context

Since backend pods are all fairly similar, it stands to reason that users would want to apply similar configuration to them. Add some cvat.backend.* parameters that are applied to all backend deployments/jobs.

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Since backend pods are all fairly similar, it stands to reason that users
would want to apply similar configuration to them. Add some `cvat.backend.*`
parameters that are applied to all backend deployments/jobs.
@SpecLad SpecLad marked this pull request as ready for review November 16, 2023 12:14
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #7148 (d470ba2) into develop (8d2d1b1) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7148      +/-   ##
===========================================
- Coverage    81.44%   81.43%   -0.02%     
===========================================
  Files          364      364              
  Lines        39904    39904              
  Branches      3699     3699              
===========================================
- Hits         32501    32496       -5     
- Misses        7403     7408       +5     
Components Coverage Δ
cvat-ui 75.54% <ø> (-0.03%) ⬇️
cvat-server 86.94% <ø> (-0.01%) ⬇️

@SpecLad SpecLad merged commit 6354472 into cvat-ai:develop Nov 16, 2023
43 checks passed
@SpecLad SpecLad deleted the backend-settings branch November 16, 2023 15:56
This was referenced Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants