Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactoring #7149

Merged
merged 9 commits into from
Dec 23, 2023
Merged

Small refactoring #7149

merged 9 commits into from
Dec 23, 2023

Conversation

Marishka17
Copy link
Contributor

@Marishka17 Marishka17 commented Nov 16, 2023

Motivation and context

This PR contains several small fixes:

  • Removed API endpoint GET /api/assets/<uuid>/public. Logic for retrieving public assets moved into GET /api/assets/<uuid> endpoint
  • Removed ability to set builders for iam_context because it is no longer needed
  • Changed approach to assigning a group to a user

Depends on #7259

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@Marishka17 Marishka17 changed the title [WIP] Small refactoring [Dependent] Small refactoring Dec 13, 2023
@Marishka17 Marishka17 requested review from zhiltsov-max and removed request for SpecLad and mdacoca December 13, 2023 10:23
@Marishka17 Marishka17 changed the title [Dependent] Small refactoring Small refactoring Dec 15, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #7149 (840ab9d) into develop (d9e7b2c) will decrease coverage by 0.02%.
The diff coverage is 95.08%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7149      +/-   ##
===========================================
- Coverage    83.09%   83.08%   -0.02%     
===========================================
  Files          371      372       +1     
  Lines        39532    39530       -2     
  Branches      3671     3671              
===========================================
- Hits         32850    32842       -8     
- Misses        6682     6688       +6     
Components Coverage Δ
cvat-ui 78.68% <ø> (-0.05%) ⬇️
cvat-server 87.09% <95.08%> (+<0.01%) ⬆️

@bsekachev bsekachev merged commit ec5fe82 into develop Dec 23, 2023
33 of 34 checks passed
@bsekachev bsekachev deleted the mk/improve_crowdsourcing_integration branch January 22, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants