Fix compatibility with older versions of Docker Compose #7170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 6ae1cff, I accidentally left behind the empty `command:` key. This works, but only with Docker Compose v2.17.1+. Since we don't actually need this key, we might as well remove it and restore compatibility with older versions. Also, rearrange the commented out code so that you only need to uncomment one block to enable the Traefik dashboard.
SpecLad
force-pushed
the
fix-docker-compose-compat
branch
from
bbc7930
to
35d6335
Compare
7 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7170 +/- ##
===========================================
+ Coverage 81.44% 81.45% +0.01%
===========================================
Files 364 364
Lines 39882 39882
Branches 3702 3702
===========================================
+ Hits 32482 32487 +5
+ Misses 7400 7395 -5
|
|
When it will be merged? |
|
@azhavoro |
azhavoro
approved these changes
Dec 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
In 6ae1cff, I accidentally left behind the empty
command:key. This works, but only with Docker Compose v2.17.1+. Since we don't actually need this key, we might as well remove it and restore compatibility with older versions.Also, rearrange the commented out code so that you only need to uncomment one block to enable the Traefik dashboard.
Fixes #7153.
How has this been tested?
Manual testing.
Checklist
developbranch[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.