Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced annotations actions #7172

Merged
merged 8 commits into from
Dec 7, 2023
Merged

Introduced annotations actions #7172

merged 8 commits into from
Dec 7, 2023

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Nov 23, 2023

Motivation and context

Actions are scripts, automatically modifying annotations within a job in certain ways
For example can be used to convert shapes from one type to another one. Potentially they may implement many different things

Related #954

But the issue is about tracks.
Added action allows removing for example:

  • Small shapes
  • Shapes with a specific label
  • Shapes of a specific type, or with a specific attribute, etc

image

TODOs until PR is ready:

  • consider rotation when converting rectangles
  • finish checks in conversion worker
  • handle close, handle cancel
  • render parameters and pass them to action
  • fix jest testing
  • changelog, versions
  • running on one object think how to implement

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev marked this pull request as ready for review November 29, 2023 19:43
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #7172 (dc07c59) into develop (eba928c) will decrease coverage by 0.15%.
Report is 5 commits behind head on develop.
The diff coverage is 64.43%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7172      +/-   ##
===========================================
- Coverage    81.47%   81.33%   -0.15%     
===========================================
  Files          365      366       +1     
  Lines        39923    39357     -566     
  Branches      3703     3644      -59     
===========================================
- Hits         32528    32010     -518     
+ Misses        7395     7347      -48     
Components Coverage Δ
cvat-ui 75.00% <64.43%> (-0.49%) ⬇️
cvat-server 87.09% <ø> (-0.01%) ⬇️

@bsekachev bsekachev changed the title Introduced annotations actions [Dependend] Introduced annotations actions Nov 30, 2023
@bsekachev bsekachev changed the title [Dependend] Introduced annotations actions Introduced annotations actions Dec 4, 2023
Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose:

  • to hide Setup action parameters section if there are no parameters
  • add more space between sections (margin-top: 56px, or a bit less)
    image

@bsekachev
Copy link
Member Author

bsekachev commented Dec 5, 2023

to hide Setup action parameters section if there are no parameters

@klakhov

If get parameters() returns null, it is hidden:
image

You may already find this logic in the code:
image

How did you get it shown?

@bsekachev
Copy link
Member Author

bsekachev commented Dec 5, 2023

add more space between sections (margin-top: 56px, or a bit less)

Set 40px.
image

@klakhov
Copy link
Contributor

klakhov commented Dec 6, 2023

Everything looks good for me now.

Just as small improvement, lets keep big margin in between sections, and a bit smaller one inside the section. Screenshot with 24px
image

@bsekachev bsekachev merged commit 52d1650 into develop Dec 7, 2023
34 checks passed
@bsekachev bsekachev deleted the bs/transformers branch December 11, 2023 09:36
@cvat-bot cvat-bot bot mentioned this pull request Dec 11, 2023
amjadsaadeh pushed a commit to amjadsaadeh/cvat that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants