Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed docs building #7294

Merged
merged 7 commits into from
Dec 26, 2023
Merged

Fixed docs building #7294

merged 7 commits into from
Dec 26, 2023

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Dec 26, 2023

Motivation and context

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Merging #7294 (03133a1) into develop (c51184b) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7294      +/-   ##
===========================================
- Coverage    83.07%   83.05%   -0.03%     
===========================================
  Files          372      372              
  Lines        39500    39500              
  Branches      3665     3665              
===========================================
- Hits         32813    32805       -8     
- Misses        6687     6695       +8     
Components Coverage Δ
cvat-ui 78.60% <ø> (-0.05%) ⬇️
cvat-server 87.10% <ø> (+<0.01%) ⬆️

@@ -137,11 +140,15 @@ def run_hugo(
git_checkout(tag.name, temp_repo, Path(temp_dir))
change_version_menu_toml(versioning_toml_path, tag.name)
run_npm_install()

# find correct hugo version
hugo = hugo110 if version.parse(tag.name) >= UPDATED_HUGO_FROM else hugo83
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that this naming pattern may break at some point, but now it seems fine.

@bsekachev bsekachev merged commit 06c6a76 into develop Dec 26, 2023
34 checks passed
@bsekachev bsekachev deleted the bs/fix_docs_build branch December 26, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants