Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct updating server ID after patching annotations #7315

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

bsekachev
Copy link
Member

Motivation and context

In some cases IDs assigned by the server are not updated after saving (e.g. in tracks and skeleton elements)
That does not affect UX, but it makes the server to remove and recreate objects instead of updating them

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Merging #7315 (c528a2d) into develop (39190c5) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7315      +/-   ##
===========================================
- Coverage    82.98%   82.94%   -0.04%     
===========================================
  Files          373      373              
  Lines        39600    39601       +1     
  Branches      3704     3704              
===========================================
- Hits         32863    32848      -15     
- Misses        6737     6753      +16     
Components Coverage Δ
cvat-ui 78.40% <100.00%> (-0.09%) ⬇️
cvat-server 87.10% <ø> (ø)

@bsekachev bsekachev merged commit 64d6d7a into develop Jan 4, 2024
34 checks passed
@bsekachev bsekachev deleted the bs/correct_update_server_ids branch January 5, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant