Don't save all fields of a model when bumping the update date #7450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpecLad
force-pushed
the
touch-date
branch
2 times, most recently
from
1574c66
to
6f8ee37
Compare
Marishka17
reviewed
Feb 15, 2024
Instead, use a specialized method that only changes the date. This provides the following advantages: * Prevents the date updates from overwriting updates to other fields that may happen at the same time. * Possibly makes the updates more efficient due to fewer columns being updated (I have no data on this, though). * Makes it easier to recognize the purpose of the query when analyzing logs/live statistics. * Makes the purpose of the code more obvious. The name of the method references the standard POSIX touch utility.
This seems to be in line with the intention of the method. This also fixes the bug where the job wasn't touched if annotations were cleared but new ones weren't created.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7450 +/- ##
===========================================
- Coverage 83.55% 83.51% -0.04%
===========================================
Files 375 373 -2
Lines 39752 39672 -80
Branches 3734 3718 -16
===========================================
- Hits 33213 33131 -82
- Misses 6539 6541 +2
|
Marishka17
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Currently, there are a lot of places where changing one object requires updating the
updated_datefield on other objects. Usually, the.savemethod is used for this purpose, which results in a generic SQLUPDATEquery that replaces the values in all columns.Introduce and use a specialized method that only changes the date. This provides the following advantages:
Prevents the date updates from overwriting updates to other fields that may happen at the same time.
Possibly makes the updates more efficient due to fewer columns being updated (I have no data on this, though).
Makes it easier to recognize the purpose of the query when analyzing logs/live statistics.
Makes the purpose of the code more obvious.
Additionally, update
__save_job_handler, where we don't want to save just the date, but we still only need to save two fields.How has this been tested?
I verified that when you save the annotations for a job, only the
updated_datefield of the task is modified.Checklist
developbranch[ ] I have created a changelog fragment[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.