Load decoder.onnx only when necessary #7564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7564 +/- ##
===========================================
- Coverage 83.52% 83.46% -0.07%
===========================================
Files 372 373 +1
Lines 39700 39742 +42
Branches 3729 3741 +12
===========================================
+ Hits 33159 33170 +11
- Misses 6541 6572 +31
|
bsekachev
reviewed
Mar 11, 2024
bsekachev
reviewed
Mar 11, 2024
bsekachev
reviewed
Mar 11, 2024
bsekachev
reviewed
Mar 11, 2024
bsekachev
reviewed
Mar 11, 2024
bsekachev
reviewed
Mar 11, 2024
cvat-ui/plugins/sam/src/ts/index.tsx
Outdated
| clicks: composedClicks, | ||
| tensor: plugin.data.embeddings.get(key) as Tensor, | ||
| modelScale, | ||
| maskInput: plugin.data.lowResMasks.has(key) ? |
There was a problem hiding this comment.
Also not the best solution, please look at efficientvit
There was a problem hiding this comment.
It is buggy when removing and optionally adding new points.
There was a problem hiding this comment.
Added logic with lastClicks
bsekachev
approved these changes
Mar 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.