Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix password handling for in-mem Redis #7577

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Mar 8, 2024

Motivation and context

The PASSWORD setting is not a URL, so it should not be URL-encoded.

How has this been tested?

Manual testing.

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@SpecLad SpecLad marked this pull request as ready for review March 8, 2024 17:40
The `PASSWORD` setting is not a URL, so it should not be URL-encoded.
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Merging #7577 (4b006f2) into develop (bfb902f) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7577      +/-   ##
===========================================
+ Coverage    83.53%   83.54%   +0.01%     
===========================================
  Files          372      372              
  Lines        39700    39700              
  Branches      3729     3729              
===========================================
+ Hits         33162    33169       +7     
+ Misses        6538     6531       -7     
Components Coverage Δ
cvat-ui 79.45% <ø> (+0.03%) ⬆️
cvat-server 87.32% <ø> (+<0.01%) ⬆️

Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanovic nmanovic merged commit 7a1fc3f into cvat-ai:develop Mar 11, 2024
34 checks passed
@cvat-bot cvat-bot bot mentioned this pull request Mar 11, 2024
@SpecLad SpecLad deleted the extra-encoding branch September 30, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants