Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Laravel 5.7 support #26

Merged
merged 1 commit into from
Sep 9, 2018
Merged

Conversation

antonkomarev
Copy link
Member

No description provided.

@antonkomarev antonkomarev merged commit b75def6 into master Sep 9, 2018
@antonkomarev antonkomarev deleted the feature/laravel-57-support branch September 9, 2018 14:58
@irazasyed
Copy link

The version constraint can just as well be ^5.1.20 (For Laravel).

It will satisfy all Laravel versions matching >=5.1.20 <6.0.0

It's unnecessary to add pipes with tilde version constraints as the second one (~5.2) is anyway going to cover all the way up to <6.0.0. It is best to use caret version range constraint for libraries and have a minimum set as that'll cover all versions.

If you still want to limit the range, you can just as well do something like ^5.1.20 <5.8 (This will cover from 5.1.20 all the way to 5.7.x).

You can test all these here.

@antonkomarev
Copy link
Member Author

antonkomarev commented Sep 9, 2018

Yeah. It's unnecessary, but it just works and I'm not feeling bad with this code because it executes only once on composer update :)
I've thought about replacing all the pipes to ^5.1.20 <5.8 but left it without changes for now because its doesn't affect on anything.
Since Laravel not following SemVer I'm not sure that 5.8+ will have same API, thats why I prefer limiting.
In next version (v4) we definitely should throw old Laravel <5.5 and PHP <7.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants