feat(base): generate new image with version 16.17.0 #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lmiller1990 this is failing in CI due to #734 not being merged yet. It's looking for Chrome to test the base image - which doesn't exist in this image. |
|
@admah I approved it - any blocker? Or something I can change here? I just ran the command from |
|
@lmiller1990 I went ahead and fixed the conflict with |
admah
approved these changes
Sep 1, 2022
This was referenced Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for regression test for
cypress-io/cypress#22795
Breaking change between Node.js versions 16.16 and 16.17.
I also need 18.6, I'll make a new PR once this is merged up.