Update log severity constants (#403)

cztomczak · Jun 12, 2018 · 0634b90 · 0634b90
1 parent ced25bf
commit 0634b90
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/api/ApplicationSettings.md b/api/ApplicationSettings.md
@@ -314,7 +314,6 @@ Accepted values - constants available in the cefpython module:
 * LOGSEVERITY_INFO
 * LOGSEVERITY_WARNING
 * LOGSEVERITY_ERROR (default)
-* LOGSEVERITY_ERROR_REPORT
 * LOGSEVERITY_DISABLE
 
 

diff --git a/src/cef_v59..v66_changes.txt b/src/cef_v59..v66_changes.txt
@@ -71,7 +71,8 @@ NEW FEATURES
 ------------
 
 internal/cef_types.h
-- cef_log_severity_t: new key LOGSEVERITY_DEBUG
++ cef_log_severity_t: new key LOGSEVERITY_DEBUG (no need to expose,
+  same as LOGSEVERITY_VERBOSE, see code comments in setting.pyx
 - cef_settings_t:
   - background_color: OSR windows can set an ARGB background color
 - cef_path_key_t (informational only):

diff --git a/src/extern/cef/cef_types.pxd b/src/extern/cef/cef_types.pxd
@@ -115,6 +115,7 @@ cdef extern from "include/internal/cef_types.h":
     ctypedef enum cef_log_severity_t:
         LOGSEVERITY_DEFAULT,
         LOGSEVERITY_VERBOSE,
+        LOGSEVERITY_DEBUG = LOGSEVERITY_VERBOSE,
         LOGSEVERITY_INFO,
         LOGSEVERITY_WARNING,
         LOGSEVERITY_ERROR,

diff --git a/src/settings.pyx b/src/settings.pyx
@@ -12,6 +12,11 @@ cimport cef_types
 
 LOGSEVERITY_DEFAULT = cef_types.LOGSEVERITY_DEFAULT
 LOGSEVERITY_VERBOSE = cef_types.LOGSEVERITY_VERBOSE
+# LOGSEVERITY_DEBUG is not exposed, as it is the same
+# as LOGSEVERITY_VERBOSE, and because it would be confusing
+# as currently passing --debug arg to app causes it to
+# set logseverity to LOGSEVERITY_INFO. Verbose logseverity
+# contains too much information.
 LOGSEVERITY_INFO = cef_types.LOGSEVERITY_INFO
 LOGSEVERITY_WARNING = cef_types.LOGSEVERITY_WARNING
 LOGSEVERITY_ERROR = cef_types.LOGSEVERITY_ERROR