Use string concatenation instead of array.join for performance #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billneff79
commented
Oct 24, 2016
| @@ -4,6 +4,7 @@ parserOptions: | |||
| env: | |||
| es6: true | |||
| browser: true | |||
| node: true | |||
There was a problem hiding this comment.
Just added this so we can lint the tests directory as well
billneff79
commented
Oct 24, 2016
| @@ -86,7 +86,7 @@ tape("path.arc(x, y, radius, startAngle, endAngle) may append only an L command | |||
| tape("path.arc(x, y, radius, startAngle, endAngle) may append an M command if the path was empty", function(test) { | |||
| var p = path.path(); p.arc(100, 100, 50, 0, Math.PI * 2); | |||
| test.pathEqual(p, "M150,100A50,50,0,1,1,50,100A50,50,0,1,1,150,100"); | |||
| var p = path.path(); p.arc(0, 50, 50, -Math.PI / 2, 0); | |||
| p = path.path(); p.arc(0, 50, 50, -Math.PI / 2, 0); | |||
There was a problem hiding this comment.
fixed linting error with duplicate variable declaration
Merged
|
I made some fixes and created PR #11. Seems reasonable, although it’s pretty hard to assess whether this is actually a performance improvement from a microbenchmark alone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String concatenation is significantly faster than array.join on almost every browser, and certainly in all of the modern ones (IE11, Chrome, FF, etc.)
JSPerf Performance Tests: https://jsperf.com/join-concat/2
Here is a a benchmark you can run of several different ways of executing the bezierCurveTo function. The one in this pull request is the fastest (click the Results tab and then click Run Bench):
ESBench: https://esbench.com/bench/580e55ee330ab09900a1a351
This pull request modifies path to use string concatenation to do the same thing instead of array joining for about a 2x performance improvement.