Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo: Add css class to edge, if they have that attribute set #151

Merged
merged 1 commit into from
Mar 31, 2015
Merged

Redo: Add css class to edge, if they have that attribute set #151

merged 1 commit into from
Mar 31, 2015

Conversation

torpedro
Copy link
Contributor

Since there has been no progress on PR #145, I redid the changes of ulilicht, because I think this is an important change to implement.

@cpettitt
Copy link
Collaborator

This behaves inconsistently with create-nodes. I'll take the PR if we can get it in sync, which should be a matter of using util.applyClass and adding tests to bundle-test.js.

@torpedro
Copy link
Contributor Author

Good point. I changed the behaviour to be consistent. The css classes are applied on the group object which also has the "edgePath" class. I also added tests for that.

cpettitt added a commit that referenced this pull request Mar 31, 2015
Add css class to edge, if they have that attribute set
@cpettitt cpettitt merged commit 09dee08 into dagrejs:master Mar 31, 2015
@cpettitt
Copy link
Collaborator

Thanks! I'll get a build out shortly.

@cpettitt
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants