Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dalek_benchmarks argument handling #567

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

divergentdave
Copy link
Contributor

This fixes how the dalek_benchmarks benchmark target handles its arguments. Replacing Criterion::default() with invocations of criterion_group!() macro allows command line arguments to reconfigure Criteron's harness. (for example, filtering benchmarks, saving and loading baselines, or changing execution time) The other two benchmark targets need no change, as they already use this macro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant