Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: possibility to pass coin symbol instead of name (id) + URL fetching unified #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

im-n1
Copy link

@im-n1 im-n1 commented Jun 26, 2018

Hey there dude,

I've added coin symbol handling. Maybe someone would like to fetch "XRP" instead of "Ripple". Now he can. Check out the diff and let me know.

You can also use the method get_coin_name() separatelly like:

>>> from cryptory import Cryptory
>>> c = Cryptory(from_date="2013-01-01")
>>> c.get_coin_name("xrp")
'ripple'

I've also tried to unify URL fetching. Check out fetch_url() method.

P.S.
I would like to contribute much more because I'm now about to use your awesome library heavily. Maybe we can also make pep-8 happy, because now whole code shines like christmas tree under flake8 :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant