Added: possibility to pass coin symbol instead of name (id) + URL fetching unified #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there dude,
I've added coin symbol handling. Maybe someone would like to fetch "XRP" instead of "Ripple". Now he can. Check out the diff and let me know.
You can also use the method
get_coin_name()
separatelly like:I've also tried to unify URL fetching. Check out
fetch_url()
method.P.S.
I would like to contribute much more because I'm now about to use your awesome library heavily. Maybe we can also make pep-8 happy, because now whole code shines like christmas tree under flake8 :D