Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dapi): identityBalance nodejs dapi-client implementation #2098

Draft
wants to merge 11 commits into
base: v1.4-dev
Choose a base branch
from

Conversation

owl352
Copy link
Contributor

@owl352 owl352 commented Sep 3, 2024

Issue being fixed or feature implemented

At this moment, we can't call identityBalance method from nodejs dapi-client, because this method is not implemented for nodejs

What was done?

Has created methods getIdentityBalanceFactore, getIdentityResponse. Also has been updated PlatformMethodsFacade.js and PlatformPromiseClient.js

How Has This Been Tested?

Manual testing was performed on a local testnet node, which has created via dashmate

Breaking Changes

No breaking changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov changed the base branch from v1.3-dev to v1.4-dev September 20, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants