Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full dashboard link in scheduler logs #7631

Merged
merged 3 commits into from
Mar 13, 2023

Conversation

milesgranger
Copy link
Contributor

@milesgranger milesgranger commented Mar 9, 2023

Closes #7543

  • Tests added / passed
  • Passes pre-commit run --all-files

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       26 files  ±       0         26 suites  ±0   12h 14m 39s ⏱️ + 1h 4m 27s
  3 498 tests +       7    3 370 ✔️  -      15     103 💤 ±  0  22 +19  3 🔥 +3 
42 110 runs   - 2 013  40 077 ✔️  - 1 982  2 006 💤  - 55  24 +21  3 🔥 +3 

For more details on these failures and errors, see this check.

Results for commit 1a49a3b. ± Comparison against base commit 689b603.

This pull request removes 1 and adds 8 tests. Note that renamed tests count towards both.
distributed.tests.test_client ‑ test_restart_workers_timeout
distributed.tests.test_client ‑ test_restart_workers_by_name[False]
distributed.tests.test_client ‑ test_restart_workers_by_name[True]
distributed.tests.test_client ‑ test_restart_workers_exception[False]
distributed.tests.test_client ‑ test_restart_workers_exception[True]
distributed.tests.test_client ‑ test_restart_workers_timeout[False]
distributed.tests.test_client ‑ test_restart_workers_timeout[True]
distributed.tests.test_system_monitor ‑ test_gil_contention
pytest ‑ internal

♻️ This comment has been updated with latest results.

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, being able to click a link in the terminal is so helpful. Especially given that VSCode auto port forwards over SSH when you do.

distributed/scheduler.py Outdated Show resolved Hide resolved
Co-authored-by: Jacob Tomlinson <jacobtomlinson@users.noreply.github.com>
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice -- thanks @milesgranger

distributed/scheduler.py Outdated Show resolved Hide resolved
@jacobtomlinson
Copy link
Member

Thanks for addressing the review feedback here @milesgranger. CI failures look unrelated. Merging.

@jacobtomlinson jacobtomlinson merged commit 700f14a into dask:main Mar 13, 2023
@milesgranger milesgranger deleted the 7543-dashboard-full-address branch March 13, 2023 12:15
ypogorelova pushed a commit to ypogorelova/distributed that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List full dashboard address in scheduler logs
3 participants