Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove weakref finalizer for Offload Executor #7644

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Mar 13, 2023

This is and always was a no-op, see #7593 (comment)

xref #7639

Copy link
Contributor

@milesgranger milesgranger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       26 files  ±0         26 suites  ±0   12h 7m 22s ⏱️ - 50m 33s
  3 497 tests ±0    3 393 ✔️ +3     103 💤 ±0  1  - 3 
44 201 runs  ±0  42 133 ✔️ +4  2 067 💤 ±0  1  - 4 

For more details on these failures, see this check.

Results for commit a24398d. ± Comparison against base commit 6c85a0c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants