-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash on missing env var in dashboard link formatting #7729
Fix crash on missing env var in dashboard link formatting #7729
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for jumping on this so quickly.
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 26 files + 24 26 suites +24 14h 37m 46s ⏱️ + 13h 46m 53s For more details on these failures, see this check. Results for commit 491fef6. ± Comparison against base commit e1944ec. This pull request removes 1 and adds 53 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Awesome thanks @milesgranger. Looks like black is unhappy now though. |
d4b988b
to
cea9ec6
Compare
cea9ec6
to
491fef6
Compare
Ready for a review @jrbourbeau @j-bennet @hendrikmakait |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @milesgranger! CI failures appear to be unrelated.
Closes #7724
pre-commit run --all-files