Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on missing env var in dashboard link formatting #7729

Merged

Conversation

milesgranger
Copy link
Contributor

@milesgranger milesgranger commented Mar 31, 2023

Closes #7724

  • Tests added / passed
  • Passes pre-commit run --all-files

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for jumping on this so quickly.

distributed/scheduler.py Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       26 files  +       24         26 suites  +24   14h 37m 46s ⏱️ + 13h 46m 53s
  3 549 tests +       52    3 437 ✔️ +       52     106 💤  -        6  6 +6 
44 897 runs  +41 389  42 650 ✔️ +39 265  2 240 💤 +2 117  7 +7 

For more details on these failures, see this check.

Results for commit 491fef6. ± Comparison against base commit e1944ec.

This pull request removes 1 and adds 53 tests. Note that renamed tests count towards both.
distributed.tests.test_scheduler ‑ test_multiple_listeners
distributed.cli.tests.test_dask_scheduler
distributed.cli.tests.test_dask_scheduler ‑ test_signal_handling[15]
distributed.cli.tests.test_dask_scheduler ‑ test_signal_handling[2]
distributed.cli.tests.test_dask_ssh
distributed.cli.tests.test_dask_worker ‑ test_signal_handling[15---nanny]
distributed.cli.tests.test_dask_worker ‑ test_signal_handling[15---no-nanny]
distributed.cli.tests.test_dask_worker ‑ test_signal_handling[2---nanny]
distributed.cli.tests.test_dask_worker ‑ test_signal_handling[2---no-nanny]
distributed.dashboard.tests.test_components
distributed.dashboard.tests.test_scheduler_bokeh
…

♻️ This comment has been updated with latest results.

@jacobtomlinson
Copy link
Member

Awesome thanks @milesgranger. Looks like black is unhappy now though.

@milesgranger milesgranger force-pushed the 7724-log-on-dashboard-link-fmt-error branch from d4b988b to cea9ec6 Compare April 3, 2023 09:34
@jrbourbeau jrbourbeau mentioned this pull request Apr 5, 2023
4 tasks
@milesgranger
Copy link
Contributor Author

Ready for a review @jrbourbeau @j-bennet @hendrikmakait
Thanks in advance. :)

Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @milesgranger! CI failures appear to be unrelated.

@hendrikmakait hendrikmakait merged commit 717905f into dask:main Apr 14, 2023
@milesgranger milesgranger deleted the 7724-log-on-dashboard-link-fmt-error branch April 14, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduler crashes in SSHCluster in 2023.3.2 but not in 2023.3.1
3 participants