Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websockets connect to port 80 by default #7772

Closed
wants to merge 1 commit into from

Conversation

crusaderky
Copy link
Collaborator

Blocks #7768

@crusaderky crusaderky self-assigned this Apr 13, 2023
@crusaderky crusaderky removed the request for review from fjetter April 13, 2023 11:19
@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       26 files  ±  0         26 suites  ±0   14h 37m 26s ⏱️ + 38m 8s
  3 554 tests +  4    3 432 ✔️  -   7     106 💤 ±0  16 +11 
44 962 runs  +52  42 632 ✔️  - 33  2 242 💤 +2  88 +83 

For more details on these failures, see this check.

Results for commit 986c01f. ± Comparison against base commit 600b993.

This pull request removes 4 and adds 8 tests. Note that renamed tests count towards both.
distributed.comm.tests.test_ws ‑ test_connection_made_with_extra_conn_args[ws://-False]
distributed.comm.tests.test_ws ‑ test_connection_made_with_extra_conn_args[ws://-True]
distributed.comm.tests.test_ws ‑ test_connection_made_with_extra_conn_args[wss://-False]
distributed.comm.tests.test_ws ‑ test_connection_made_with_extra_conn_args[wss://-True]
distributed.comm.tests.test_ws ‑ test_connection_made_with_extra_conn_args[False-ws://]
distributed.comm.tests.test_ws ‑ test_connection_made_with_extra_conn_args[False-wss://]
distributed.comm.tests.test_ws ‑ test_connection_made_with_extra_conn_args[True-ws://]
distributed.comm.tests.test_ws ‑ test_connection_made_with_extra_conn_args[True-wss://]
distributed.comm.tests.test_ws ‑ test_implicit_port[-80-ws://]
distributed.comm.tests.test_ws ‑ test_implicit_port[-80-wss://]
distributed.comm.tests.test_ws ‑ test_implicit_port[:123-123-ws://]
distributed.comm.tests.test_ws ‑ test_implicit_port[:123-123-wss://]

@crusaderky crusaderky closed this Apr 13, 2023
@crusaderky crusaderky deleted the ws_port_80 branch April 13, 2023 14:40
@crusaderky
Copy link
Collaborator Author

Turns out that the scheduler thoroughly relies on these functions to raise ValueError to indicate that there's no port. I'll find out a different avenue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant