Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test_asyncprocess.py::test_simple #8085

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

crusaderky
Copy link
Collaborator

Relax timings to fix flaky test:

        t1 = time()
        while wr2() is not None:
            await asyncio.sleep(0.01)
            gc.collect()
            dt = time() - t1
>           assert dt < 2.0
E           assert 2.083622694015503 < 2.0

@crusaderky crusaderky added the flaky test Intermittent failures on CI. label Aug 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       19 files   -        1         19 suites   - 1   10h 32m 58s ⏱️ - 22m 52s
  3 752 tests ±       0    3 646 ✔️ +       1     104 💤 ±  0  2 ±0 
34 112 runs   - 2 365  32 510 ✔️  - 2 298  1 599 💤  - 66  3 ±0 

For more details on these failures, see this check.

Results for commit af47fc0. ± Comparison against base commit ef6d4bf.

@crusaderky crusaderky merged commit 9b8f3b8 into dask:main Aug 9, 2023
20 of 26 checks passed
@crusaderky crusaderky deleted the flaky_asyncproc branch August 9, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky test Intermittent failures on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants