Dedicated job for memray tests #8104
Conversation
|
CI still fails and |
Ah, thanks for the link. My CLI was somehow crashing and I was more or less guessing how the output could be interpreted :) This is unfortunate. Does anybody have an idea on how to do this then? My two ideas are
|
|
Those are the options I came up with as well. Another less-than-ideal one would be moving it into a dedicated package/repo that could have a lower-complexity CI. |
Don't like this either. I like that this kind of tooling is just packaged and shipped with the core. I think I'll go for the extra CI step ¯_(ツ)_/¯ |
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| memray = pytest.importorskip("memray") | |||
|
|
|||
| pytestmark = pytest.mark.extra_packages | |||
There was a problem hiding this comment.
I added this marker to have the job run really quickly. We could also mark with memray explicitly. No strong preference.
There was a problem hiding this comment.
I kept it general because we're requiring strict markers and this felt a bit too specific but this doesn't really matter either way
|
FYI I accidentally published the branch to dask/distributed instead of my fork. I suspect this PR will be merged very quickly so I won't migrate the branch. mea culpa |
Closes #8103
I think this is available on 3.10
"Proper" fix would be conda/conda#8089