fix(ui): Do not show manage in settings when no permissions for it Fi…

…x/prd 787 (#9261)
datahub-project · Nov 21, 2023 · d9de854 · d9de854
1 parent 0187480
commit d9de854
Showing 1 changed file with 19 additions and 18 deletions.
diff --git a/datahub-web-react/src/app/settings/SettingsPage.tsx b/datahub-web-react/src/app/settings/SettingsPage.tsx
@@ -141,24 +141,25 @@ export const SettingsPage = () => {
                             )}
                         </Menu.ItemGroup>
                     )}
-
-                    <Menu.ItemGroup title="Manage">
-                        {showViews && (
-                            <Menu.Item key="views">
-                                <FilterOutlined /> <ItemTitle>My Views</ItemTitle>
-                            </Menu.Item>
-                        )}
-                        {showOwnershipTypes && (
-                            <Menu.Item key="ownership">
-                                <TeamOutlined /> <ItemTitle>Ownership Types</ItemTitle>
-                            </Menu.Item>
-                        )}
-                        {showHomePagePosts && (
-                            <Menu.Item key="posts">
-                                <PushpinOutlined /> <ItemTitle>Home Page Posts</ItemTitle>
-                            </Menu.Item>
-                        )}
-                    </Menu.ItemGroup>
+                    {(showViews || showOwnershipTypes || showHomePagePosts) && (
+                        <Menu.ItemGroup title="Manage">
+                            {showViews && (
+                                <Menu.Item key="views">
+                                    <FilterOutlined /> <ItemTitle>My Views</ItemTitle>
+                                </Menu.Item>
+                            )}
+                            {showOwnershipTypes && (
+                                <Menu.Item key="ownership">
+                                    <TeamOutlined /> <ItemTitle>Ownership Types</ItemTitle>
+                                </Menu.Item>
+                            )}
+                            {showHomePagePosts && (
+                                <Menu.Item key="posts">
+                                    <PushpinOutlined /> <ItemTitle>Home Page Posts</ItemTitle>
+                                </Menu.Item>
+                            )}
+                        </Menu.ItemGroup>
+                    )}
 
                     <Menu.ItemGroup title="Preferences">
                         <Menu.Item key="preferences">