Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev): fix env file overrides for profiles #10194

Merged
merged 1 commit into from
Apr 3, 2024
Merged

fix(dev): fix env file overrides for profiles #10194

merged 1 commit into from
Apr 3, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Apr 3, 2024

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Apr 3, 2024
david-leifker
david-leifker approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@david-leifker david-leifker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@david-leifker david-leifker merged commit 522a508 into master Apr 3, 2024
36 of 37 checks passed
@david-leifker david-leifker deleted the compose-profiles-override branch April 3, 2024 16:19
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@hsheth2 @sleeperdeep
fix(dev): fix env file overrides for profiles (datahub-project#10194)
4b0e856
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @david-leifker