feat(ingest): add snowflake-summary source #10642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
hsheth2
force-pushed
the
snowflake-summary-source
branch
from
99565d8
to
d144781
Compare
5 tasks
treff7es
approved these changes
Jun 12, 2024
| @@ -979,58 +988,88 @@ def generate( | |||
|
|
|||
| ### Automatic Lineage Extraction Support | |||
|
|
|||
| This is a summary of automatic lineage extraciton support in our data source. Please refer to the **Important Capabilities** table in the source documentation. Note that even if the source does not support automatic extraction, you can still add lineage manually using our API & SDKs.\n""") | |||
| This is a summary of automatic lineage extraciton support in our data source. Please refer to the **Important Capabilities** table in the source documentation. Note that even if the source does not support automatic extraction, you can still add lineage manually using our API & SDKs.\n""" | |||
There was a problem hiding this comment.
Suggested change
| This is a summary of automatic lineage extraciton support in our data source. Please refer to the **Important Capabilities** table in the source documentation. Note that even if the source does not support automatic extraction, you can still add lineage manually using our API & SDKs.\n""" | |
| This is a summary of automatic lineage extraction support in our data source. Please refer to the **Important Capabilities** table in the source documentation. Note that even if the source does not support automatic extraction, you can still add lineage manually using our API & SDKs.\n""" |
| @@ -651,6 +651,7 @@ | |||
| "redshift = datahub.ingestion.source.redshift.redshift:RedshiftSource", | |||
| "slack = datahub.ingestion.source.slack.slack:SlackSource", | |||
| "snowflake = datahub.ingestion.source.snowflake.snowflake_v2:SnowflakeV2Source", | |||
| "snowflake-summary = datahub.ingestion.source.snowflake.snowflake_summary:SnowflakeSummarySource", | |||
There was a problem hiding this comment.
I didn't see the definition of dependencies for this source. Shouldn't it have snowflake_common as a dependency?
There was a problem hiding this comment.
resolved in a follow up PR
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Jun 25, 2024
yoonhyejin
pushed a commit
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist