Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bigquery): use get() instead of hassattr for view labels #10756

Merged
merged 5 commits into from
Jun 20, 2024
Merged

fix(bigquery): use get() instead of hassattr for view labels #10756

merged 5 commits into from
Jun 20, 2024

Conversation

ethan-cartwright
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jun 20, 2024
ethan-cartwright and others added 2 commits June 20, 2024 14:08
@ethan-cartwright @hsheth2
Update metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/bi…
0836eab 
…gquery_schema.py

Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
@ethan-cartwright
move to one line
625c544
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Jun 20, 2024
@ethan-cartwright ethan-cartwright changed the title fix(bigquery): check that type of view.labels is str to fix typeError on None fix(bigquery): use get() instead of hassattr for view labels Jun 20, 2024
@hsheth2 hsheth2 merged commit b3dccb0 into datahub-project:master Jun 20, 2024
57 of 58 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@ethan-cartwright @hsheth2 @sleeperdeep
fix(bigquery): use get() instead of hassattr for view labels (datahub…
cb5c1c4 
…-project#10756)

Co-authored-by: Ethan Cartwright <ethan.cartwright@acryl.io>
Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
yoonhyejin pushed a commit that referenced this pull request Jul 16, 2024
@ethan-cartwright @hsheth2 @yoonhyejin
fix(bigquery): use get() instead of hassattr for view labels (#10756)
381a1ec 
Co-authored-by: Ethan Cartwright <ethan.cartwright@acryl.io>
Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethan-cartwright @hsheth2