fix(ui): checks truthy value for last ingested

[pinakipb2]

Checklist

• The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
• Links to related issues (if applicable)
• Tests for the changes have been added/updated (if applicable)
• Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
• For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

When lastIngested is 0, 0 gets rendered in the screen.

Summary by CodeRabbit

• Bug Fixes
  • Improved the reliability of displaying the last ingested date by updating the conditional rendering logic.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The update in the EntitySidebar.tsx file concerns the conditional rendering logic for entityData.lastIngested. Previously, the existence check was based on a truthiness evaluation. This has been changed to use a double negation (!!) to explicitly convert entityData.lastIngested to a boolean, ensuring a more rigorous and clear conditional check.

Changes

File	Change Summary
datahub-web-react/src/.../profile/sidebar/EntitySidebar.tsx	Updated the conditional check for entityData.lastIngested to use double negation for clearer logic.

Poem

In lines of code, a tweak so small,
To ensure precision, hear the call.
A double !! for truth to find,
Clarity in logic, peace of mind.
The sidebar's now more sharp and bright,
Oh code, you shine with pure delight! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b8af2b9 and 5691990.

Files selected for processing (1)

• datahub-web-react/src/app/entity/shared/containers/profile/sidebar/EntitySidebar.tsx (1 hunks)

Additional comments not posted (1)

datahub-web-react/src/app/entity/shared/containers/profile/sidebar/EntitySidebar.tsx (1)

49-49: LGTM! The truthy check is correctly implemented.

The use of double negation (!!) ensures that lastIngested is rendered only when it is a truthy value, preventing the rendering of 0.

[rtekal]

@chriscollins3456, when you get a chance, can you please approve and merge this PR. Thank you in advance.

[rtekal]

@hsheth2 Thank you for approving the PR. When you get a chance, please merge the PR.

[hsheth2]

Looks like CI is failing due to a lint issue

[warn] Code style issues found in the above file. Forgot to run Prettier?

> Task :datahub-web-react:yarnLint FAILED

[pinakipb2]

Looks like CI is failing due to a lint issue

[warn] Code style issues found in the above file. Forgot to run Prettier?

> Task :datahub-web-react:yarnLint FAILED

Its addressed.
Thanks !

[rtekal]

@hsheth2, I think you cancelled the workflow and it is not re-running. Or actually my question: you added the label 'merge-pending-ci', how does it come out of 'pending' state?