feat(ingestion/powerbi): link cross workspace dataset into assets #11560
+842
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
hsheth2
requested changes
Oct 8, 2024
| # set the dataset for tiles | ||
| for tile in dashboard.tiles: | ||
| if tile.dataset_id: | ||
| tile.dataset = self.dataset_registry.get(tile.dataset_id) |
There was a problem hiding this comment.
is this dataset registry global across all workspaces?
also, do both workspaces need to be ingested for cross-workspace lineage to work? I think we might need some docs updates if so
| @@ -218,6 +218,7 @@ class Report: | |||
| webUrl: Optional[str] | |||
| embedUrl: str | |||
| description: str | |||
| dataset_id: Optional[str] | |||
| dataset: Optional["PowerBIDataset"] | |||
There was a problem hiding this comment.
how do dataset_id and dataset interact? is one filled initially, and then the other populated later?
would be good to add some comments to make this more clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.