Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for Kubernetes-based deployment #1602

Merged
merged 5 commits into from
Mar 24, 2020

Conversation

bharatak
Copy link
Collaborator

This is the first version of Kubernetes based deployment. This PR contains kubernetes YAML configuration files. If this work is in alignment with the owners, I can go ahead and create Helm chart for easy installation of Datahub on Kubernetes. Open for feedback. Thank you.

Copy link
Contributor

@mars-lan mars-lan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Will let @keremsahin1 review the Kubernetes config files.

contrib/kubernetes/README.md Show resolved Hide resolved
contrib/kubernetes/README.md Outdated Show resolved Hide resolved
@mars-lan mars-lan changed the title Support for Kubernetes based deployment feat: support for Kubernetes-based deployment Mar 22, 2020
contrib/kubernetes/README.md Show resolved Hide resolved
contrib/kubernetes/README.md Show resolved Hide resolved
## Setup
This kubernetes deployment doesn't contain the below artifacts. The idea is to use the original helm charts for deploying each of these separately.

* Kafka and Schema Registry [Chart Link](https://hub.helm.sh/charts/incubator/kafka)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We depend on Confluent Kafka right now, changing dependency to Apache Kafka might need small refactoring in the codebase I suppose (expect minimal change on kafka producer & consumer). But, this is not a big deal, we can change it to Apache Kafka. The only reason we depended on Confluent Kafka was ease of use because they had their Docker images ready in Docker Hub. It was so easy to use.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confluent Helm charts are also available. Need to test it e2e. Will change the link to point to this https://github.com/confluentinc/cp-helm-charts/tree/master/charts/cp-kafka

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that'd be easier.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Changed the Chart Link

```
kubectl apply -f datahub-configmap.yaml
```
3. Run the below kubectl commands
Copy link
Contributor

@keremsahin1 keremsahin1 Mar 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 4

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

contrib/kubernetes/README.md Outdated Show resolved Hide resolved
contrib/kubernetes/README.md Show resolved Hide resolved
## Setup
This kubernetes deployment doesn't contain the below artifacts. The idea is to use the original helm charts for deploying each of these separately.

* Kafka and Schema Registry [Chart Link](https://hub.helm.sh/charts/incubator/kafka)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that'd be easier.

contrib/kubernetes/README.md Outdated Show resolved Hide resolved
@bharatak
Copy link
Collaborator Author

bharatak commented Mar 24, 2020

This PR contains the basic Kubernetes YAML files. In the next PR (currently working), I'll provide the helm charts and update the README accordingly. If everything is good, can this PR be merged? The WIP branch for helm charts is here

Copy link
Contributor

@keremsahin1 keremsahin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keremsahin1 keremsahin1 merged commit bfc6c6f into datahub-project:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants