-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for Kubernetes-based deployment #1602
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Will let @keremsahin1 review the Kubernetes config files.
contrib/kubernetes/README.md
Outdated
## Setup | ||
This kubernetes deployment doesn't contain the below artifacts. The idea is to use the original helm charts for deploying each of these separately. | ||
|
||
* Kafka and Schema Registry [Chart Link](https://hub.helm.sh/charts/incubator/kafka) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We depend on Confluent Kafka right now, changing dependency to Apache Kafka might need small refactoring in the codebase I suppose (expect minimal change on kafka producer & consumer). But, this is not a big deal, we can change it to Apache Kafka. The only reason we depended on Confluent Kafka was ease of use because they had their Docker images ready in Docker Hub. It was so easy to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confluent Helm charts are also available. Need to test it e2e. Will change the link to point to this https://github.com/confluentinc/cp-helm-charts/tree/master/charts/cp-kafka
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, that'd be easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Changed the Chart Link
contrib/kubernetes/README.md
Outdated
``` | ||
kubectl apply -f datahub-configmap.yaml | ||
``` | ||
3. Run the below kubectl commands |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
contrib/kubernetes/README.md
Outdated
## Setup | ||
This kubernetes deployment doesn't contain the below artifacts. The idea is to use the original helm charts for deploying each of these separately. | ||
|
||
* Kafka and Schema Registry [Chart Link](https://hub.helm.sh/charts/incubator/kafka) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, that'd be easier.
This PR contains the basic Kubernetes YAML files. In the next PR (currently working), I'll provide the helm charts and update the README accordingly. If everything is good, can this PR be merged? The WIP branch for helm charts is here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is the first version of Kubernetes based deployment. This PR contains kubernetes YAML configuration files. If this work is in alignment with the owners, I can go ahead and create Helm chart for easy installation of Datahub on Kubernetes. Open for feedback. Thank you.