Support for volta in web client #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keremsahin1
reviewed
Jun 22, 2020
datahub-web/package.json
Outdated
| @@ -71,5 +71,9 @@ | |||
| }, | |||
| "dependencies": { | |||
| "yarn": "^1.10.1" | |||
There was a problem hiding this comment.
Do we still need this line?
There was a problem hiding this comment.
I think we do. Volta is its own special tooling environment that reads from the "volta" property. However, in this case it does not interact with any other part of the client build logic which should still rely on this dependencies line if checking what yarn version we are using. Though the two versions should match haha.
mars-lan
approved these changes
Jun 22, 2020
keremsahin1
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist