Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): simplify event IDs for function invocations #4398

Merged
merged 9 commits into from
Mar 23, 2022
Merged

feat(ingest): simplify event IDs for function invocations #4398

merged 9 commits into from
Mar 23, 2022

Conversation

kevinhu
Copy link
Contributor

@kevinhu kevinhu commented Mar 12, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 12, 2022 •
edited
Loading

Unit Test Results (build & test)

  92 files  ±0    92 suites  ±0   13m 7s ⏱️ - 1m 30s
674 tests ±0  615 ✔️ ±0  59 💤 ±0  0 ❌ ±0 

Results for commit 84d8d89. ± Comparison against base commit 9fbb521.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 12, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   52m 3s ⏱️ - 2m 24s
   365 tests ±0     365 ✔️ ±0    0 💤 ±0  0 ❌ ±0 
1 672 runs  ±0  1 641 ✔️ ±0  31 💤 ±0  0 ❌ ±0 

Results for commit 84d8d89. ± Comparison against base commit 9fbb521.

♻️ This comment has been updated with latest results.

@kevinhu kevinhu force-pushed the simplify-function-analytics branch from bf7ba39 to 1195a3f Compare March 14, 2022 18:32
rslanka
rslanka suggested changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@rslanka rslanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kevinhu, could you please resolve the merge conflicts?

@rslanka rslanka added the pending-submitter-response Issue/request has been reviewed but requires a response from the submitter label Mar 23, 2022
@kevinhu @rslanka
Update metadata-ingestion/src/datahub/telemetry/telemetry.py
84d8d89 
Co-authored-by: Ravindra Lanka <rslanka@gmail.com>
rslanka
rslanka approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@rslanka rslanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rslanka rslanka removed the pending-submitter-response Issue/request has been reviewed but requires a response from the submitter label Mar 23, 2022
@rslanka rslanka merged commit a7b0275 into datahub-project:master Mar 23, 2022
@anshbansal
Copy link
Collaborator

FYI #4479 to reduce log levels

maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@kevinhu @rslanka @maggiehays
feat(ingest): simplify event IDs for function invocations (datahub-pr…
29d09d1 
…oject#4398)

* Simplify function call events
Co-authored-by: Ravindra Lanka <rslanka@gmail.com>

Co-authored-by: Ravindra Lanka <rslanka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 left review comments

@rslanka rslanka rslanka approved these changes

Assignees

@rslanka rslanka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevinhu @anshbansal @rslanka @hsheth2