Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(search) - add DATETIME FieldType #4407

Merged
merged 2 commits into from
Apr 5, 2022
Merged

feat(search) - add DATETIME FieldType #4407

merged 2 commits into from
Apr 5, 2022

Conversation

aditya-radhakrishnan
Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan commented Mar 14, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 14, 2022 •
edited
Loading

Unit Test Results (build & test)

  96 files  +  4    96 suites  +4   11m 46s ⏱️ - 9m 24s
687 tests +15  628 ✔️ +17  59 💤 ±0  0 ❌  - 2 

Results for commit 4047c1a. ± Comparison against base commit f0230b0.

♻️ This comment has been updated with latest results.

rslanka
rslanka approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@rslanka rslanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rslanka rslanka merged commit 8610c29 into datahub-project:master Apr 5, 2022
aditya-radhakrishnan added a commit to aditya-radhakrishnan/datahub that referenced this pull request Apr 5, 2022
@aditya-radhakrishnan
feat(search) - add DATETIME FieldType (datahub-project#4407)
983eb9d 
* feat(search) - add DATETIME FieldType
aditya-radhakrishnan added a commit to aditya-radhakrishnan/datahub that referenced this pull request Apr 5, 2022
@aditya-radhakrishnan
feat(search) - add DATETIME FieldType (datahub-project#4407)
ab7f8b8 
* feat(search) - add DATETIME FieldType
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@aditya-radhakrishnan @maggiehays
feat(search) - add DATETIME FieldType (datahub-project#4407)
e6df4b2 
* feat(search) - add DATETIME FieldType
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 left review comments

@rslanka rslanka rslanka approved these changes

Assignees

@dexter-mh-lee dexter-mh-lee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aditya-radhakrishnan @rslanka @jjoyce0510 @dexter-mh-lee