Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(snowflake): stop querying when no mix/max dates for usage #4480

Merged
merged 1 commit into from
Mar 25, 2022
Merged

feat(snowflake): stop querying when no mix/max dates for usage #4480

merged 1 commit into from
Mar 25, 2022

Conversation

anshbansal
Copy link
Collaborator

Currently we continue querying even if there is no usage data. We should stop early

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 24, 2022 •
edited
Loading

Unit Test Results (build & test)

  91 files   -   1    91 suites   - 1   7m 53s ⏱️ - 5m 48s
597 tests  - 77  545 ✔️  - 69  52 💤  - 7  0 ❌  - 1 

Results for commit f0014ba. ± Comparison against base commit a1ebc6b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 24, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       5 files         5 suites   47m 22s ⏱️
   371 tests    371 ✔️   0 💤 0 ❌
1 702 runs  1 664 ✔️ 38 💤 0 ❌

Results for commit f0014ba.

♻️ This comment has been updated with latest results.

@anshbansal anshbansal closed this Mar 24, 2022
@anshbansal anshbansal reopened this Mar 24, 2022
@anshbansal anshbansal closed this Mar 24, 2022
@anshbansal anshbansal reopened this Mar 24, 2022
treff7es
treff7es approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@treff7es treff7es merged commit ab36ac0 into datahub-project:master Mar 25, 2022
@anshbansal anshbansal deleted the stop-fast-snowflake-usage branch March 25, 2022 10:02
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@anshbansal @maggiehays
feat(snowflake): stop querying for usage data when no mix/max dates (d…
36987b9 
…atahub-project#4480)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @treff7es